Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 88.51% 88.41% -0.10%
==========================================
Files 35 35
Lines 2003 2003
==========================================
- Hits 1773 1771 -2
- Misses 230 232 +2
🚀 New features to boost your workflow:
|
Member
Author
|
docs failure is addressed separately in #846 |
TomNicholas
reviewed
Jan 5, 2026
| [arr.manifest._paths for arr in arrays], | ||
| axis=axis, | ||
| concatenated_paths = ( | ||
| cast( # `np.concatenate` is type hinted as if the output could have Any dtype |
Member
There was a problem hiding this comment.
I presume this is because of numpy's type promotion rules.
TomNicholas
approved these changes
Jan 5, 2026
chuckwondo
reviewed
Jan 5, 2026
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this failing workflow - https://github.com/zarr-developers/VirtualiZarr/actions/runs/20701631805